I have created issue-#127 for the StdFolds bug observed by Doug.
See http://redmine.blackboxframework.org/issues/127.
Actually this is not related to StdFolds but has first been observed when using the new folds.
The explanation of the bug is here: http://forum.blackboxframework.org/view ... t=20#p4626.
A first proposal for a fix is in the topic branch.
See the diffs at http://redmine.blackboxframework.org/pr ... bffe12c4b9.
A text view simply forwards the PositionMsg to its controller, which then clears the auto scroll range.
However, it needs a careful review and tests.
This has some potential for surprises but so far I have not experienced any.
I mean, it could be that the "buggy" behavior was used somewhere and would now be changed unintentionally.
Note: Currently the fix ignores msg.focusOnly. I don't know if this is a problem.
This is the major open question, I believe.
- Josef
issue-#127 ShowRange does not clear the auto-scroll range
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
- DGDanforth
- Posts: 1061
- Joined: Tue Sep 17, 2013 1:16 am
- Location: Palo Alto, California, USA
- Contact:
Re: issue-#127 ShowRange does not clear the auto-scroll rang
Good going Josef and luowy!
I just tested the changes and that works for me.
-Doug
I just tested the changes and that works for me.
-Doug
-
- Posts: 1700
- Joined: Tue Sep 17, 2013 12:21 am
- Location: Russia
Re: issue-#127 ShowRange does not clear the auto-scroll rang
Tested this version
http://blackboxframework.org/unstable/i ... c1.661.zip
works well.
I think that this issue is ready for voting.
http://blackboxframework.org/unstable/i ... c1.661.zip
works well.
I think that this issue is ready for voting.
- Josef Templ
- Posts: 2047
- Joined: Tue Sep 17, 2013 6:50 am
Re: issue-#127 ShowRange does not clear the auto-scroll rang
I have removed the explicit forwarding of the PositionMsg from TextViews because
this is done anyway in TextViews.ShowRange (via broadcast). TextViews is no longer changed.
I also have added a focus check now in TextControllers when handling the PositionMsg.
Works as before for our test case.
For the total diff see http://redmine.blackboxframework.org/pr ... bffe12c4b9.
- Josef
this is done anyway in TextViews.ShowRange (via broadcast). TextViews is no longer changed.
I also have added a focus check now in TextControllers when handling the PositionMsg.
Works as before for our test case.
For the total diff see http://redmine.blackboxframework.org/pr ... bffe12c4b9.
- Josef
- DGDanforth
- Posts: 1061
- Joined: Tue Sep 17, 2013 1:16 am
- Location: Palo Alto, California, USA
- Contact:
Re: issue-#127 ShowRange does not clear the auto-scroll rang
Simpler is better.
Works for me.
-Doug
Works for me.
-Doug