issue-#75 fixing text search with 'Word Begins/Ends With'

[Ivan Denisov]

Josef, according syntax rules in text dot can not be just before word. There should be space before word, tab, para or open bracket.

From my point of view Log.String is one word.

I think, that this question should not be debated now. In the 1.6 the dot is not in the LeftTerminator procedure.
I agree with Robert that we should not include two much futures now in 1.7.

About rare Unicode symbols. They are rare, and do not used in documentation and sources.

[Zinn]

"Log" is a word
"String is a word
but "Log.String" is not a word.
The point "." should be a terminater for left and right.
- Helmut

[Ivan Denisov]

I have used all my arguments

Really I am never using this flags. More interesting would be regular expression search by the default.

[Josef Templ]

Really I am never using this flags. More interesting would be regular expression search by the default.

I have tried to use the options in the past but I have got the impression that they don't find all the occurences,
so I was also not using them for some time. And now, just as an accidental side-effect of working on this issue,
I know why it is buggy.
The good news is that it can be fixed easily and it does not cause any complications but
actually simplifies the code. Isn't this good news for BB?

Regarding your argument that 'a..b' is illegal:
This is wrong in two senses.
1. You can define a CP set s := {a..b}.
This is legal. There is no requirement to put spaces inside.
2. Such a text can also occur outside of a CP source text.
The text search is not a feature specifically targeted at CP texts.
My users are secretaries and business experts and they never look at CP source code
but they produce texts and should be able to successfully use the text search with all options.

I agree that regex search would also be nice to have sometimes but this is
a separate issue. As far as I know there are several CPC packages available for that.

- Josef

[Zinn]

I checked Josef's proposal about deleting LeftTerminator & RightTerminator and adding Terminator. It works fine. It make the program easier and the result of the new version is more logical than the result of the old version. I found no sample where I prefer the old version. The symmetrical use is a big advantage.
- Helmut

[Josef Templ]

The required changes are committed now in issue-#75.
For the diffs see http://redmine.blackboxframework.org/pr ... 8e79cdae64.

It also includes a trivial adaptation of the search dialog layout.
The label fields for the options were so small in the past that some of the
label text has been clipped at the right.

In TextCmds I deliberately retained the two functions for left and right terminators in order to
- preserve the program logic and produce fewer changed lines
- be prepared for any possible future requirement for reintroducing asymmetric left and right terminator sets

- Josef