issue-#70 resetting a menu item label to its original value

Post Reply
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

issue-#70 resetting a menu item label to its original value

Post by Josef Templ »

This bug is due to an optimization in HostMenus.PrepareMenu where a menu
item label is only updated in the underlying Windows menu item when it
differs from its standard value. Resetting a changed label to its standard
value is thereby not possible.
The proposed fix is to remove this optimization, which does not produce any
visible advantage anyway because the involved menu handling WinApi calls are
fast enough.

For the issue see http://redmine.blackboxframework.org/issues/70.

For the changes see http://redmine.blackboxframework.org/pr ... 3cd5beae40.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#70 resetting a menu item label to its original va

Post by Ivan Denisov »

Seems reasonable. Let's vote for this!
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#70 resetting a menu item label to its original va

Post by Josef Templ »

I agree. Its time for voting on this.
Post Reply