issue-#63 fixes in StdStamps

[Robert]

I do not like the way this Draft version adds new comments.

Case 1: Open a new Stamp. Add a comment (eg "Potato"). The form displays a meaningless date of 0000. Now list the History.The comment is invisible. Save it to disc. Now list the History. It is visible. Now open the Comment editor. It is hidden; you have to click the Age field to see it. This makes it easy to overwrite it with a new Comment without knowing.

With my version when you first open the editor to add a comment it tells you the date the comment is associated with. Add it, then list the History. You can immediately see it is there; there is no hidden Comment queue. Save to disc. It is still visible in the history. Now open the Comment editor. It is immediately visible, and when you overwrite it you are doing so explicitly in the Editor field, not accidentally.


Case 2: An old Stamp with no comment for today. Add a comment. Close the editor. List the history - the comment is not visible. Open the Editor, The comment is also invisible. There is no way to know it is there, but save to disc and it appears without warning.

With my version it is always immediately visible in both the history, and in the comment editor. This is much more user friendly.


Case 3: An old Stamp with a comment for today. I open the editor, write and apply a new comment.
With the draft version I am unaware I have overwritten an existing comment, with my version this is immediately obvious in the editor.

A bit later I think about saving, and list the history, which I now think is ok (I have forgotten about the new, and hidden comment.) I save. The hidden comment overwrites the existing comment without warning or notification. This issues do not arise with my version.


In summary it is much simpler, for the user, if comments are applied and visible immediately. Deferring applying them, and in the meantime hiding them, is not helpful. (I know that finger prints cannot be pre-viewed, but I don't find that a problem.)

I agree that there is "Surprisingly tricky and buggy stuff in this module", and considering / implementing this behaviour takes a lot of time and effort. But in fact I think there are several places where my code is simpler than the current suggestion (mainly because the first comment is not treated as such a special case) although there are a few cases where it is less so. On balance it is simpler.

[Robert]

If anyone wants to compare the behaviour of the draft Stamps with my version I include a test version in a module StampsRdc so it can coexist with the draft or Oms versions.

To use it add the Menu items

Code: Select all

	"Insert &Stamp"	""	"StdStamps.Deposit; StdCmds.PasteView"	"StdCmds.PasteViewGuard"
	"Insert RDC Stamp"	""	"StdStampsRdc.Deposit; StdCmds.PasteView"	"StdCmds.PasteViewGuard"
	"Copy -> RDC Stamp"	""	"StdStampsRdc.Copy"	"StdStampsRdc.CopyGuard"

If you select a populated StdStamp the last Menu item creates and inserts an "Rdc" version with the same entries for test purposes.
Two files: "Mod/StampsRdc.odc", & "Rsrc/StampsRdc.odc".

Code: Select all

PacCoder.Decode /.:C....6/o......./B.4w.N..j.3:.R./V.4o.Q./n.36.N./X.0s.Pk/Y
.4:..../rZCWq0Q6oE3rCenz6QW0T4yU6DY3bX9H41e1O181Q1cFn6L2IzYN0Ug:NxsU.d0.pG3k
jPqNEkoB7HEtE.VKzgVrR.sIzkGb/yHkyVSxjXImU4/gc3kXzk/Y/qy.wVJajkJYUvQQKFBV9YXM
Z1iBzr0dnGVIdEEN6WWwhYl/7t7.HrYYS80eB5e/8ap50vhPxcp3Gx8OHF32onOcCOBN/Wqe1N2x
yc//ZGRe2KOUpUoYSUaCEUKO127001E:FyEuUBx/VuVn0dac5yfI:ECSDdUbUN/EV:I3N:ERQbkH
47cBQLY77H0Q7Oy69GM.rE0EQ7XsaLno/42mEfwa0iRLx2kB5sVdVaaX5lIxo3WnxzDUTKd:YT0x
sjwZJ:G4xVTftRXjq.ORXioSykyfq0uQHq2rDMRZRv4MxDN2SmqgsdbTX0ahobgeI2sSY2RU4uxa
Fs:sc:08I4fzmeEXBEsegyzOk0SQMfi9DHWf44nX6kQb1mQ4JDNXnXUsjBC.V0LyBlVKnVDb6fWt
X7kKC2uKnUkb3XC3eHnV5b2n0zC7zdrnrUiHW.b/YuzC:0QDIs2BQNko228:se7locXC6aQRybQF
LSQ7ZTxC4iWLgLdveknhV4YFQbQLEeYI/r1G6QM4NxSDQVoJDzw:zw30ligtFlaK/TzyP.nk2Ghk
wzFFz.UbmsHfw28qtKxyuW6tSwIumSy9rISxzuIwUw52KnxsFNSVLvkchBvl2abv5dXMLtqHvn/v
uTNTT9G2Cyw5N.zj9dbHcsXcZ35jVXCvTJlJrMjkbpRCKjEycywKWNaylV9JH.sZl1E5ulrjadpv
qxvoOBokNxg8.R5zKXiVnKfTCb2TDcRBtSJBLkLOLH8.RTrFgta8jVq1woiaU3W7oNpT65Zvj5n.
DOyRfrOIJDCabh4VU1ghIGBiBTCYuytyQY5rHa8rXRqddDD5JiHdnIEVcqvsQL/hL7/9.1Y.rZhe
RD6IU7DZetY2OjrwUXyMjbzVSvZdsG.9G06n0g/w6vKhEhaPq0aL32Lzzh60ttOKTMItDP/Ch9nt
ovVmG08EoZqm28bY.3IWt.DSfzh1KoG07FPHDZn7SEmCTwOSHrhG.Jvoq8O49V8.mFKabdwgp536
4t66OiY/xrSYTve7oqFW1KG.Z0OMPy1uhB6H7/6hBulY.8HHJVKrJ.yJzOmah2rOc0sepnM27gD2
UxzuYHyaBnTdc:.gmzgiDqawEl.Tme6PMU2w9LsU72Wf4xom7YHoqmgKretM/1xBzZU0w/dk76Sb
.HnOPesM/0J:k96hyID18W7KbuYk/xo2CPiZhg6LTgpyoJlkU4azwq5.EBMH8v5sGuOD57qaQnOQ
3B9bjZ69G:E/lcl.4udvxRjICjH.YsRy81hMBOpqMuOpsCIYkGW2Nw65:zOnVlN9FZqTZrH08yhW
6q1WrvUVoYqVe/kXXMCI5y0JB/mjVTCSM81t5pvlUssuuDU/OQ/LWwUb/dKcpW0OnVUQ4MxyIY:k
iYIwxkQIQkHgJEvg5CGM6XlTsJizGgW:pfEUuXs5e255W/kSU6sr51sK81cUyXTWr7Mz7XP56ekQ
qC5O2Uaq5p8:rY.SE9sKsWXURUCMbHbQBEIBRaEMX:pEtOXQr8C1buJkjrZjVaPP/kZDD78jR1:x
sqDofKHU4DyHe/oPXxMSudt57lXcmVOftfHu9/Yao5CufkNDarOBPigS9v:XfJOiLM:M1ELasqSH
L3H/JmehC121tNYjbVvkckQ9cKiFrhcCPdmocgOdLfN0IOR59FhFh554uxCHUT05HzijpMBHG8pM
orUuspsOuot4LrdnOvRCNaTvHChvQcK3FOjTaxNB2n/TcCbt0m4wSSPw6c2:MJ9nRzx5z07bRmXc
mdKB8mFFjbW4xnBLT/xMJNfdE9rgo6EOzxelfIJ:OWGLhq0cPzzv11GP/Nv9ybCrR7sFDyMqwZjy
55TlmE1v10mbDDUDxiT09vssPF1ZPiNP/IpOMVXF4Ny26BFtngwvT9x.c7gYNKvc4I7xHeulBEhp
udIbDUE8m/:teuzrjoFSUBP6ZyzmUMk6QHw5aaU1:HG5tD3pMz1XYD1fHzNQtBesNHRaEG8q.ezm
wlKrGIk1W146NsDLckShLuiy7gdcy1TpkRepJ3wwy2FslIevw/hKZxVeJvW1tQXF:pHofbPSTogq
yydfxuhihDZP/602oSNHiIGS/4B/pWVM2gvzytVdjpGNioWugtg0B:zkE0R64TRpPWSoTHTOSxNd
5uZns0F0.r4sxy/GoZifa87Oi49F080MwYujWdJox5qYbk7cN04p:Hv5WF5HmU63qcNsUSbVTz0D
RlrkFDWBcDBUzyt2DOc2C/oFjwxS6P::UIHdOHkr:NWb/MS50pCm.VL6NerLnijJj547l:HJaheS
PBDWdivUMpJ3qZrFKEuNz9DUZmqvmrelKz0NhsrC.kjeUXnyQu0jy/vT63LoJG6VKpFC9ZfRD1qO
LePqathUt/3.7s69TthPVu:bG:l1zffKsuT1Hx0tlXjSXusnMCLEGSOJeHQ6eCJftxFWJuJFPzij
dVjP46nuDhszikwQarFjrfkVBz52MwEzKvOoilMZXxuZ11xVDyMhldlOwS/g8CpMpjwOLirNnFuN
dxQwJofx.F8RHYJXVsZvhmlRV6b31uVSTGBP3KbF7CHXTDux96mWpZeoG/xFxTNctfiSmaT0NShH
Obxm9QWf27:KIr/03YG7wjHLWhiNwEizDejHmvs0dzFzlfuh6IFLHrTkZbhMmmDQIoa91NqW9RnP
qtar:8s7YH8lCOKWdOaV.pQsjtNJ5hLatffnVaMUH6N:3Nis/1N:xisuulg7PR6WSbkvwOjZhnjq
tWiEqEe2f/Sw:Epare54axGQ4g5rc284PhSequH.4hocDmleByqxR14jBNFyu1cGl2BW259VnqxE
RwQMjiF.qb/zl1qew4XB1plD17MvrwEh9bitcfDCBjqYBRpfPhPSaTHFa2nNOoFX2QRs9nLhyy.h
d/i3i4bXOxpl/9q1bblGT0Hqiav0vk8re7Ugf3oVziH8Gf9IzhsC7ltjstIoG1y8HZPGG7PR3N9e
QSPxmRsWfM9OIjjlksgq./rlGrppPlIvBzVXRlgz.9vEUrcBIFwceUKdZM:z7.NU7nmHyXvIJvz:
/9c:z5kqH4qosKlx9rKPSa6PKhhZP2acP6Q2TEKksqmO:2X8hDZG7gD:0RMTddPyPwP6c6wFN4iR
eOxCBHF3EtFj8IyCViaSKY7gkDDc3kEwKtkhbdHlVHKEwsrRDRzxYqi10jU5Xn90z4YrjlC5QzDV
ivnzqDbrxHa.u2pVqe:lowOMU96phlCwNzVnJwWCIhbhOgH1KCGe/OKk0IMop7i5uc2xYfk4hj/j
F2buwddalCDptNJlrBjyX2tNdjkagcPbC0zwwpy/rbT2gL3rmTvqUNLpBJvPt3D2if.HuFR9NapE
scOFv.tKU9BFK7gznSR99mkv1s:bzQOEDGjgLBr6EQee64Ce92mCGPtl7jPy8RMH/R9qqPmXfinD
jrzl71W0CVQtf:9Uy8tTGbNcfJ.XlULEOYCOa8UdfJfhr7FXyI5OjZvHiL1JkqHfHbxnTtNGiWsq
1ObUqi6LkB1KBmNyq2V4NQmeT:2UEsX8:UTJ25tUwggcawrbCCMeV:2HnCLcGlpaqG:0mcmBlHkM
1DHka/5IGrnoKJflfuoRuc6aZ3ppX/GpF1c7mcG8UPyutz6jCWsNcZF9JREkSBZddVlQleq5td4s
CTmvO:D4LtwDwm0.8Eb2g41s64hcf0JYfp.DknJpUXEKEXYnPw.ix2rktsRbt:zfTm:eUXwNDa.I
h2LPKvuZPs9xVdkni43fPMG:Y5D92CuX1TDtgodE8NvP0odZkNfzpx:W9q5DKcN2eGK5yzFSqJ8L
NRezTLFC.9jKr5vDCcWRf0b1NYGmltmpcNo4tM.RJhjj8RKlUUKBz3lmp4RrnUoTryMXKypBEoSz
7xtuhMuUUziJEEE8uLCtxtY21xbIg/M0G3KYgl:MWmEuapGj/6ohGr0uIDDPUJtsIdnn70Fhsd3s
ZzaDaDW8xdkbdSoaYnqvrTZTbQms2c61mui8uPHCI5vHOZet5VTFdnRwRX/Uv4rwxzPW:llVpN9b
MVx/9Bir0uqcMvZGZn7gtPLCODi.GHp9gm5FlD0cFp1XtB4qt9Hna7id84zfJiHppP3.tC8tfG3I
WK5Tb:qiM/3FBnjCSKUcviXHG7RJWIduaN9hNbxEcrsOw15yrJg0c3k.y9aS5iHrzPGD4WVSvQLO
z:gk7n7zPxwKFaMlPTiRSCaTOKHlNx49N4tILxEBkvx86bOPYGdz8ymXgmcsKSdxGBtkndexGHqH
p62hRDaiBrYjaOzd2Pcj5rRywRoaYJtRH8pP4vW5twGbPK43Q.CLmGVKimvQgox:mQJLvFNNIwDs
eGhks9z6ep2Jx5fQlQM2.nX6IxhojD5aulB99sWPR5bujjrvgN5NRNZULR4x4:nVY5plNgjQc5a0
q6HoqUla1a0jKdhcnUGtyHqthLQQw7t:6g7uyZZ2WYHYMw9PYf/GWKu5Y65hctn50reLchxTVrSR
GzcqapGabEP:vOPYRTqF9hDy26bsC8UTgIu3pd19XpVoQEfLWbuhvzUoT9naPjQQ8yRygU:kQJIG
Wuqp1vqtydH4P64vaJO4zLOOOjYyQhumo3/MlhSOTsX07pwRVyHOTNgzeatPw8xq.oJIE46Od/sM
QnmCQ9ItQjj7Sg3Fnb63vWo93i7msptd0swkorybhKY3tSnuevxBtTBWvFVKI.QwXevTfT5D/KJL
KchpocR0QXQKeTSLrUn12.1IwFgqj1a/CCKboyFPQH4vHpgNCxaWMGdzt9OosPuGNWmkN3R21Xhs
j0G9eEzqf.uWM0pq4QwjcJnjj2jgaLortnbbTnKwW3/H1fpsgDnHm30nX1yqxcHdfX:cuYN2eXnh
K2p/fqN9Q6Jh.YZvaFNJk:XE7hbxGe7xny2y2LZRBkFcSNhS.mOtP:xBLfRLm8IlE3OaUzViCpSh
LNERMOZS.2ijQ6Vy.h6OPl.XvDqciNjDkCykhuysZz5d5KSq8VmXGKT:KyGXBwyVULdq83l1EWYG
qSsHn4eCwCrgow//an/ZZRutvVI1i2MaZDrMIOFvpo75QPUMVBlXFMyhDksxFN05GHXqyruZdDCo
dcowY2iNf/fzyHxbmvIVJszHebGpGRprbcjihxGBSpjNUpjHUxM9D2RGHhses1QTLSmmr593alfz
wkhD795jrsJRd9376BpXKkV7DzQXenfJeIvw7y:KnkwVf2RQZNYEXSTRFO710b6w/.o0VlBbQurt
iNvWqhvumpXbvtb2RF:WQsgaNabCQpL6FmiS09PJI6JGMpRYxPa2jlyIDMjfzB5CY6.sod9N5yo/
sh17BwdListbjNh0qDtNj7MO8NKOHTpwIkz3paywvMLKjMx9TDxkK:zm8D08/PoRvBR7a4DToxeQ
asWfLlEHv.QYm9DXJM0y/TsDkWoYczMIxa51psR10S/jv3x2qpC9RlRvX3i79P7lEToH.mpELXom
Ew1XCwb9TN01pv9yNk2PBZ7B::Y5gxaDdolpRv0FmhpIVlr0P:CyS2vIUHv5xJzQcmxkbWLgoQR9
MMfilsfxTMfcOhTKFct8rxclEVT92yZkSP5hy5xnZN0YvoSttfI.fbPj2cR00gKvI2zmURrm4i4I
qjm56UMQH:i0:xcaXhpcs.frLzSjJ5iapPKZJDRqfjG:W6UIlzGhDKcuLmJ81xgBYgEprddMhT89
fKnDJp9YY8xo19SBzz8eYOcwDob:8WkmvaDHYiXBGnVZ7.skS5kk3.pHIpzb54yRUdOUepUw.OGf
S../v6kOL:K6P2wgF4wafRjgngy2uHFnMolHQZMho6buczGqOl:nUJmB3iUTb/KtEzQN0.jd8R3i
aZycEUKfepeqn3:FnfrIca9T:yPaMOHSCQKk5noz6T5D7Ty/Q/m/66aEuebtsRCJmanJwn1GQ81t
bbP3.gHBJQ0Cy1QrQaEnvE68Ja4emvBPoM35UMXBT1kIQ6R0GglzoB7xftzHpdkTk1GOceymnJcH
y8vmTY8:qSsw6xh6sMlmM5e5XKxzfO0j1pCROgrbvaPQHJsmZchDtk1n1oUkPP9HVDHN6hlFTRGv
clY:KYQgeCWYl/zIFG71NfBY/vPDPOKjXiKX6JNJJo4M54lVLoN/ECs9N3QEarVZeRuiWQwmg:Ok
lKoGpDejT0arJm.sKMUHt2iUsLqwqzWbk74DTsfB4qu5I:LerjBFgnpQFaWtWvqlv1R65IU4YPEV
nsYrmfavCPwU8XC6Qr7x8Ri6xqq6FwTgp2C3Zs724vsUj:aZcYv38zVrwNlxPg2sXPWdg3fyUjPl
VEjx26VjXVTpgHrt89ZpfT.2cI2mgnhKlrt3:PWCij8bT2wXITazOqIkc81/3ZzHBX4HqaXs4t2S
uTmJ9WylR/VFj7uhKguqC1HvJfyiBV/Nt:nQBCfhHopMMx:Ut32:zYct2JjZkREdvRKFpvhxrvhq
WBUtMjRxf.ScujxKZUrOz5rNJtwhdqBJqe3CXi3ubseuVoD:Zji4Hds6sr1MLhZPO7mh4FhkcExJ
ltvqfgjHht2xzj1tvmmf1yx8ay9v:kCuL2qdkegRRQ1KWitQPY4BTQgd7.SX:0xWZDn4U4G7hxN1
E7niDP9xt7C3CoqxX8rDWpC8DoTZll.litn5Tt9jgnp.qnlhmuces90jssmtNJF:qLZarOYxjDaC
RB5NZfwiL8JWZVXmwfR8ykDs8b1pENs/hkjbTKJ1IQFrjiVim/zNadYVw4P:S:Szjl/ynyToWbiF
zXQG/VM6nVzVjzzc1solYxijJUcHNxjv2BONqoluTpo3Rui6G3.JzsQe8mhZzEWfw3LsPFJyR:n2
orLGtT2mCL5O3HBcTCHu8lStO0DmZEirV9NTp:aGkPi6eK7RGaH7CKee2cOI3ofYVDRm.GIDpbub
y:DFGjk:IkYT67VeihBk93otbKkvNZSnCw0ZL35JCUeQZTj2.po:VD1jSypPe9mvhtphM0Q2Cjip
ZXwJWirVTfE9CPG7OfSvqLII.YhnyanXedNliZrSdv4l32QejU6hNzB9TySXjyJvSBSBcimy7TkR
S1urkNF0g6hFmLVqtUlZgS5rq03Sk97jhgVeEsNTa2XHdEig0siHffzBJ8rMUt18Y5qcx3vIukm1
R07PVZCRUsnuFcvZenS9nkM23M:DnhqS2tlTfr3VpcYqU4ZdZp.MXeS133ypVTQtsuJ..9uLPogq
O0MWuWDrtfxRr/pbYDD4P21njxdOgTT3PIKRiSEXugdiIepzD2e7ItHfS4gt:gQo9IN8SyYTj4oG
aQsqiEr:N7/qnDFpCra/IpcOlX/5:aNqsCuPzr86j/YFy0Pw/l:9gvXhkdswwdJhz0/xPp0ZW:Zh
WWOdIH/9OYgbrgDKZQH6Z0g7TsKQiBWywezzxVQtuyd:7O4QnGZt5s3MmbQgm6zcjxJWPKxo1C3Y
mJD4n8/U2H3ljhnHUr4PgmnzYLOh9QF.huFxJBxifh2.2pXL.8aELttceBllVH9pjyJxL::xQLr1
b6uC2jgiCdwh423V:wn2kCKnrH:ygqnc4DuL/ZrQejam7eVB.ZuQdencTLDW8IQx52prJwawvibd
bfz5DWn5FKba/etQXTY8zeYoXQXLStWBBi8NbZytzBvKN11gEPn7fX5rLcVPJ4Tozlc5qUkp70Vs
EU1zVI5lFgOsmTqqDPkfzcaZ7SzpFhOpZuWWhxBXXmGqT6e4j6xNhDGIr4Zlcvp27Lc7l:6926Jd
zR9:0KQjOI9SdwmUyl:01J6demQkr8GKb6O2ewTJE:MTVcdamfrCLy5XDoDlxyCjaLIRLeqJuS5e
i2r7OrT/i:8vQKYyG9h0MjhmqkTVLlxD6mKaLyuhe7WJO/gonGjttP.8ai463OQ/1K492k2Rp06/
38Ncmk5slV8kVBbpd1wwZ1L2dU7dtTxTRfcLTLNxZggtV:iQmOnIypri0Vw:v7rgIR7PGUo/nw1k
BayMbzjZc.PS72ko1:GXbUDhf/Vzs6ihQCoXkP7sQ6QQRcoD1g6K3Mla3nIkB0kVycSzG6sKqvE0
Kkm2hHwUQT/ZTKTlt4x0ydqiVfZ2Gs:Mv/qPIR.8/E/JpvRQdDMIg3LxD8EGD.f1G3QgT8QsX8Dg
fWfHuxiTRnxMs/ox0wZL7/dShkQCYMs0NOgxhHhF7/zh/0ajf1Qs1dL9PRyvYWXoyaat4lSCviX0
K4vfU/CcSd5u1OGlojG4SxHp91OD5eS.vN5B8URzgbXhZIw2bhDEfdnsmZkYkXtIDzS7SChIdXbB
FRd0YDedJT/Truvuq.Twk8CMs6ryby9jwa6Vx6s9zz0E:cNTmr6vSR18/R:TYUMW1RnHnEtNEpw6
Sw4eTHik43jrMCvjkxCqMGUvRq/xp94yv3wKkqjakU0BNtpL2ZxD3twilUbCPORzU0VZVaZW.S2K
E9yyNRz7Zzh11k6pssPL2G4i8SmZO/qka207iqOIGmMWRrB0PWX4Xr/vlhF:RcUCxg4lGavb0T3P
Wd:vH8FbBYBiZHvwq1ehpb5P:Tgd.cRchR3Sjjrlp1GJqVRDNMZbbD/Jffrunx/6daxaG2f9hTmv
/H5pB/DF8MBT7gdGW607SlRnNV5:ZfqHlWNeDUhN5Q2RRph8x6jMXUYI6boknO913iqhCYWjggnw
G6p7ymHdjjzR0Gbi4dLxTnfN2uH5CXyEoCd7ntg:hyQWcMtXJcievPBcwzpfVVmuZaMJXZ/Fn033
8HvK7hGN4dKw/bELmvy89Xn5ZxXYwStMUpQcj2KWqTYwe3pHfxN5T6gRzTO2KNybQ7Zi21QrbKKq
8/ypd7KXVrjzQljSsQ7xvMs/PkYyV0ZEOCdt3ZDWO6oHJriCXU6xwI8t.iUmilf5rdd4bUM6ka1f
1m:9OnmMbJyCZHkRP2E3wtCQFgxHpqwyza57GrR49quhrudZ7:EG2DYs0/UPtCCXar5DneZwaJIB
MxHNE74VEFO:Qcv0aP4xPGoJEeVtXhMLQMrS6NBWLkc4K:U8SvzFBo7lGgevut2OXyfVHuT1V9ow
sL.lqr2dxOIa9vlaiqTWKZwBn6b3qLXpq4mFuHIM5g1SdHmKd9IkKipHtDBPRxvLwZR:9eYBBPeN
xHuJclQWQeJThaaTVcmExYsDswuXMi.UlBWt57n3i8BZoE.uGxPsYBpQj3KaZsTILtXwyD6ScrS3
gsu6r.i0eUpMLQLEwBPLhfMVIC.4qSGsd5SMprO4uyofcSoig3t.iE7SMPQZ9JkUgTNM1g64:7jd
a8eJHrKGLPu/EpIPMr7cqluTdgFvhBqGUTap33trNqjn7KEywwHu6lxq8sLboftLHCMMZEyqdN7/
va8kcWUabhYfOikJeENyXaPzdsbByR64KCMQOtZk.iP:1MzqlO1cs3uxlVfce38j.b4Dv.02CBc7
6Bgiw/tZeqkIFgXfNeexwM3w.9f.0RLKGrx:vnrU/gdSDU/o1NnGwE88QDr5CWqQrvNmeJYjBe4V
OVqc1tOV3KcFRe.jzysZSkvIDup14eIROVQFOobUkEhHDKebfKcQrXxq51hEqsnRFqaq0Wltf00p
1Cceukq3iXV3qcjaGu71wcjG94bIl7OMVNY:aKlQjwxDrHYamcrPP5rfWN1UaTQ79RBaOFaD:VwL
BGB:VIn/uZYvreh3I:brcTa5hXj4oyzDlWfjD5xe2kytvhTzY/FyHR6i2VMF0mgrd0nbRyykIzzz
U36.Qk/m.4:.9k/H.5E.ME/h.5..Qk/G.4E.Mk.i.4w.N./X.....E1o5a9q/x2/cQlh7m56Ublj
c01t/NsmolUuUqUmUr.u2Qm3l3Dt4Ec914TS6.8EUBIVQ9qxaI:B1GIoCI.6Jjv6RrEC3Dw2dkTY
wDcLjPsp:c/UP8/Q6zw.N.RjUD71t.VTUf7/qssgWP0564l05QPzi3HaV0dEUUm/33tP7W01mE.b
j7/eeaU0MgUnRqojqfQFbNm6O6gaaPR/nFee:KrEP6bjr.6:eHh6M4z/d2KH6H5YE8N126W006:J
QIPUBzzr6km/4s39Kt0HiyiuZ.9G2xwJLlk6QU8vVGJ06bm7/bx9X19r.:70mgJ.ggG47.I6s9Xu
oXskqvjY3fPdMIdyQsBBmHzlXQiG1fiG1sknv63si4FSEdX0D/HM00EBr6n6FRkb0EqJl9KsNer1
nTG:Ix/CO0Mo.NKUGB/cO.3fETaUKB.8QcIYI4tO8VBPfLPvHXMWURuEcm.Cf3GqF7ibm6JR3Gff
v6gI26dFFEeIUMdQFEmWVl3ErUp2OXeRQHjLWVwBlEaBfxr30:N1pWVpYIEJOFJQr:I.L7Q78JwI
5C75FHuWbJ3.jbZxazh.mlITPon:C/mVyKSBb2IS0Kw29LxGzHWjwEn4vbvh8nL0PXj9sOddqVhf
vholT4vo:Q.Mwkk4yq2peDJC8dbgIK1x16ZMIz3.kSYvMbUThqomkb::8046:B.MEf0ZXhVOElqU
lE/YRq0n4Qa4En:.kRs401hV1Li8qdvR7uBLM6RRq00fZVbRvRo7vtv0F0OkkZVYnV6:15f/K4:k
:D5NUMk.l./UDk:MUMxEk7rqEM2Wg6x11ILxJu9cN8RfHfWOgRNK4efukT5K42Y:0mbQ:LUMqRNh
zg:GVQ45k:a8RPq4W1Sv.0ueksCRmOK4nEjm7EkMNxW:vV.DY.IT3f5TlNq67gx8UjDjqBCh/fe.
U7eI2EVHg2.8JjuLuOCsrdTlJ82Z8KrawIsw7uIZuI6YTHUO8GvGWwDZ8rUjqRT2eq/vCIu8DDt7
xT1yCjvGXgz/jjfziBdIF3:MkudynbEU7qzuk8T109jIK8TNR3DNe.cCGnIfVRUy4EdyXPk4ZFEI
JjC10Eb5G78tyEcJIdH4oIjDGUmbm128L1Wp8T4ObOZBmZ/dERGbFGav.qVI0izPOdEJfcgoqXoa
Z3j/HazGYmXCKuopDGiLGrRjCaFxo8zzzU
AtEndOfEncoding

[Josef Templ]

Robert, thanks for the feedback.

Most of your comments are now in the latest commit.
http://blackboxframework.org/unstable/i ... a1.262.zip

As a general remark, I would like to point out that the purpose of my exercise was
to produce a blend of the old behavior with the new requirements.
The old behavior should only be changed where it is required but not only because
the implementation can save 3 lines of code. With the old behavior I mean
- the seq nr must start with 1 for the first entry shown in the history
- the history contains the saving points of the document, i.e. it lists all times where the file has been saved and nothing else.
This behavior to me is the core of StdStamps and was not a problem except for implementation details.
The edited intermediate values can always be seen from the dialog and we are talking about rather
rare editing operations.

> Case 2: An old Stamp with no comment for today. Add a comment. Close the editor. List the history - the comment is not visible. Open the Editor, The comment is also invisible. ...

I cannot reproduce this behavior. When I open the editor the comment is visible.
Are you sure that you have observed this behavior? Is it fixed in the latest commit?

In order to provide more control over the insertion of a new entry versus the overwriting of an existing entry,
I added an option together with its own guard in the dialog.
This gives us full control over the behavior even if there is no comment set.
It also makes it explicit that there is an option before you press OK and it avoids a modal dialog.
(BTW, your Yes/No dialog was confusing to me because it creates a new entry when it actually says that it modifies the date. With your dialog I was able to create several entries with seq nr = 0.).

The programming interface has been extended in order to provide all the available information.

The change of the HandlePropMsg is not included because:
- it follows a standard pattern also used at several other places
- the outer WITH groups together the sequence of inner WITH cases and makes the reading easier
- the outer WITH jumps over all inner WITH cases in a single step when the msg is not a Preference message.

- Josef

[Zinn]

Josef your version works as you described. The forward declaration of the procedure Update can be deleted.
- Helmut

[Robert]

1 - I appear to be wrong about my "Case 2" comment!

2 - I can't replicate the adding of several comments with serial no 0 with my version; in fact I can only obtain serial no 0 when saving an empty document. But discussing my version is probably not the most productive thing to do at the moment.

3 - With your latest version I can produce several entries, with different comments for, for today's date. In my opinion having more than 1 entry per day is definitely not the original behaviour, and is undesirable. We must reach agreement, I think, on whether this point is acceptable before we can agree on all the other finer details.

4 - I accept that the meaning of the two options in my Modal dialog was not as clear as we would like. But the three options you provide for adding a new comment when there is already a comment with today's date seem even more confusing.
The options are:
a) Use "Age" 1
b) Use "Age" 0 with "Force New" checked
c) Use "Age" 0 with "Force New" unchecked.
What precisely are the different behaviours, where are they explained, and do we need these three different options? - I don't think so.

5 - Sometimes when you Edit a Stamp the changes are visible in the Stamp listing immediately (see a above). Sometimes they are not visible in the listing until after the Document is next saved. I still think it is simpler, for the user, to make all changes visible immediately. But I will compromise on this point rather than continue this discussion for ever!

Good grief - this Module is proving more difficult that I would ever have imagined!

Regards

[Zinn]

4 - I accept that the meaning of the two options in my Modal dialog was not as clear as we would like. But the three options you provide for adding a new comment when there is already a comment with today's date seem even more confusing.
The options are:
a) Use "Age" 1
b) Use "Age" 0 with "Force New" checked
c) Use "Age" 0 with "Force New" unchecked.
What precisely are the different behaviours, where are they explained, and do we need these three different options? - I don't think so.

Another approach could be to delete the "Force New" check box and oboe the rule
a) Use "Age" 1 for changing the comment without force a new entry
b) Use "Age" 0 insert a comment and force a new entry

- Helmut

[Josef Templ]

Robert, I agree that three options are one too many.
Following Helmut's proposal, I have removed 'Force New'.
Selecting Age = 0 implies Force New.

There was only one situation that required the third option and it is not relevant:
It allowed one to create multiple entries per day even without a comment.

Having multiple commented entries per day is required if you reach
several significant milestones within a single day. This is not impossible.
It must be left to the user to decide how to handle such a case.
A heuristics built into the stamp view cannot know it.

Further changes are:
Dialog.MapString used for header labels in the history.
docu updated.

And last but not least:
I have added a special first line in the history if an Age 0 comment exists.
It shows a 'seq nr. = ####', which means that a seq nr. is not yet available because it has not been saved.

http://blackboxframework.org/unstable/i ... a1.265.zip

See the diffs at:
http://redmine.blackboxframework.org/pr ... 805539926d

- Josef

[Robert]

I have had a very quick look at the latest version...

My initial impression is: "Much better"!

[Zinn]

Thank you Robert and Josef for the cooperation. It is good teamwork.
The result here would not exist without Robert’s groundwork and Josef's revision.
It is an example that a team get better solutions than one person by its own.
Now it is ready for voting.
- Helmut

[Josef Templ]

A (hopefully final) improvement is to avoid the indirection via field 'Age' for selection of old/new
entries and to use a list box with sequence numbers for that purpose.
I have prepared such a variant in http://blackboxframework.org/unstable/i ... a1.269.zip.

Also ShowHistory for new entries is slightly improved in order to align the
appearance of new entries in the history with the information in the dialog box, i.e.
1. it shows the current date, and
2. instead of #### it uses the same term as in the 'Seq. Nr.' list box, viz. 'new'.

@Ivan: redmine currently cannot produce any diffs.
Could you please check this?

- Josef