issue-#44 unicode content of links&targets saving wrong way

User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#44 unicode content of links&targets saving wrong

Post by Josef Templ »

I have now looked more closely into the implementation and have
committed my proposal for the changes into issue-#44.

- elimination of version 0 reverted
- comment for version history added to Link:Externalize
- speed up of HasWideChars by common subexpression elimination
- Strings.Find avoided in Link:Externalize for version = 2
- small refactorings for reducing the amount of version specific code
- change list in chronological order as usual

I think the changes are in a good shape now. I have tested them with a number
of different test cases and found no problems so far.

Please have a look at the diffs at http://redmine.blackboxframework.org/pr ... 997bb3e11b.

or the overall diffs at http://redmine.blackboxframework.org/pr ... 4b15c28ec5.

- Josef
Ivan Denisov
Posts: 1700
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#44 unicode content of links&targets saving wrong

Post by Ivan Denisov »

Works well. I am ready for voting :)
Zinn
Posts: 476
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main
Contact:

Re: issue-#44 unicode content of links&targets saving wrong

Post by Zinn »

Josef, it is a very good solution!
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#44 unicode content of links&targets saving wrong

Post by Josef Templ »

Thanks for the votes. I have merged the changes.
Post Reply