issue-#40 fixingconcatenation of Unicode character constants

Post Reply
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

issue-#40 fixingconcatenation of Unicode character constants

Post by Josef Templ »

similar to #39 this is a bug fix in the compiler. It lifts an accidental limitation
that disallows Unicode character constants to be concatenated.
See http://redmine.blackboxframework.org/issues/40.
The proposal by Luowy is well done and I have included the changes to the topic branch.

For the changes see http://redmine.blackboxframework.org/pr ... 8f663c42b9.

Since there is probably not much to discuss, I will create the voting immediately.

- Josef
cfbsoftware
Posts: 204
Joined: Wed Sep 18, 2013 10:06 pm
Contact:

Re: issue-#40 fixingconcatenation of Unicode character const

Post by cfbsoftware »

Josef Templ wrote:It lifts an accidental limitation...
What evidence is there that it was accidental?
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#40 fixingconcatenation of Unicode character const

Post by Josef Templ »

cfbsoftware wrote:
Josef Templ wrote:It lifts an accidental limitation...
What evidence is there that it was accidental?
The involved sequence of if-elsifs is rather complicated and there is a special
elsif for the concatenation operator further below. This special elsif is not executed because
another elsif is TRUE before and this applies only for Unicode character constants.
In addition, there is nothing in the language report that explains the difference between
concatenation of SHORTCHAR constants and Unicode constants.
The fix essentially skips the inappropriate elsif in case of concatentation
and allows the cascade to proceed until the elsif for the concatenation operator (+).

- Josef
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#40 fixingconcatenation of Unicode character const

Post by Josef Templ »

I have locked the voting and merged the changes into master.

- Josef
Post Reply