issue-#32 Folds arrows display

issue-#32 Folds arrows display

Postby Ivan Denisov » Mon Mar 23, 2015 3:37 pm

Folds are displaying wrong way both in Wine (in Linux) and Russian language Windows. With English version of Windows folds displaying well.

folds_both.png
folds_both.png (4.99 KiB) Viewed 9420 times


The fixing changes required the Wine detection code and also I updated the platform constants. Also the part of problem is that windows versions are more than 10 now, so I am suggesting to change constants 100-199 - windows, 200-299 - mac, 300-399 - linux.

Mostly I took the code from the CPC and my Red versions and improve the code a bit.
Please take a look at the solution:
http://redmine.blackboxframework.org/pr ... 63a053d22f (old)
and try the updated version:
http://blackboxframework.org/unstable/i ... a1.080.zip (old)
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#32 Folds arrows display

Postby Zinn » Wed Mar 25, 2015 6:50 pm

Ivan Denisov wrote:The fixing changes required the Wine detection code and also I updated the platform constants.
Also the part of problem is that windows versions are more than 10 now,
so I am suggesting to change constants 100-199 - windows, 200-299 - mac, 300-399 - linux.


I would like to know the opinion of the other members.
Changing the platform constants has noting to do with the folds arrows display problem.
Do you agree with this change of the platform constants?
Zinn
 
Posts: 472
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main

Re: issue-#32 Folds arrows display

Postby Ivan Denisov » Wed Mar 25, 2015 8:30 pm

Helmut, you are absolutely right, that is not good practice to unite bug fixes and features in one branch.

So, I made the step back changes and now there is no constant changes, only Wine detection and folds changes. Please, take a look:
http://redmine.blackboxframework.org/pr ... 63a053d22f

Try this demo:
http://blackboxframework.org/unstable/i ... a1.080.zip

This is how it became to look in Wine:
wineAfterFix.png
wineAfterFix.png (1.35 KiB) Viewed 9395 times


In Windows the arrows became good as them should be without cutting.
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#32 Folds arrows display

Postby akastargazer » Wed Mar 25, 2015 8:48 pm

Folds arrow display fix is very important. I'd like to see it within a BlackBox pack.
User avatar
akastargazer
 
Posts: 6
Joined: Wed Sep 18, 2013 9:24 pm
Location: Russia, Yaroslavl

Re: issue-#32 Folds arrows display

Postby Zinn » Thu Mar 26, 2015 6:17 am

akastargazer wrote:Folds arrow display fix is very important. I'd like to see it within a BlackBox pack.


The current CPC Edition already has this fix about fold arrows display.

The link arrows have the same problem and is not fixed yet.
Zinn
 
Posts: 472
Joined: Tue Mar 25, 2014 5:56 pm
Location: Frankfurt am Main

Re: issue-#32 Folds arrows display

Postby Josef Templ » Thu Mar 26, 2015 9:31 am

It is true, the CPC edition contains a lot of fixes regarding wine detection and Folds display.
I would propose to separate these changes into two issues:
a) fixing platform detection for wine and new windows versions
b) fixing the display of Folds etc. under wine and certain Windows versions.

Note that 'b' requires 'a' to be fixed in order to
detect the underlying platform correctly.

'a' (in CPC 1.7) also introduces auxiliary functions for detecting any Windows version, see
Dialog.IsWindows(), Dialog.IsWine() etc. This abstracts from the underlying encoding of the
various OS versions such as Win XP, Win Vista, etc. and allows the client modules
to adapt themselves to new Windows versions to be introduced later.

There are several files involved and the changes are not trivial.

- Josef
User avatar
Josef Templ
 
Posts: 2038
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#32 Folds arrows display

Postby Ivan Denisov » Thu Mar 26, 2015 9:57 am

Josef Templ wrote:There are several files involved and the changes are not trivial.


Not very much files:
Dev/Mod/Debug.odc
Dev/Mod/RBrowser.odc
Host/Mod/Dialog.odc
Std/Mod/Folds.odc
Std/Mod/Links.odc
System/Mod/Dialog.odc

I executed this changes during the first attempt and can repeat if we decide about constants.
http://redmine.blackboxframework.org/pr ... 63a053d22f
Further discussion better to continue in new thread.
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#32 Folds arrows display

Postby Josef Templ » Thu Mar 26, 2015 1:00 pm

please see http://forum.blackboxframework.org/viewtopic.php?f=41&t=198 (issue-#33)
for the changes required for platform detection of Wine and the new Windows versions.

- Josef
User avatar
Josef Templ
 
Posts: 2038
Joined: Tue Sep 17, 2013 6:50 am

Re: issue-#32 Folds arrows display

Postby Ivan Denisov » Thu Mar 26, 2015 6:12 pm

There is new idea! To remove fonts dependency at all.

I made some prototype. The only single file was changed — StdFolds. The face of this controls should be improved, however the idea is clear.
http://redmine.blackboxframework.org/pr ... 63a053d22f

Demo version:
http://blackboxframework.org/unstable/i ... a1.085.zip
Ivan Denisov
 
Posts: 1698
Joined: Tue Sep 17, 2013 12:21 am
Location: Russia

Re: issue-#32 Folds arrows display

Postby akastargazer » Thu Mar 26, 2015 6:19 pm

Ivan Denisov wrote:There is new idea! To remove fonts dependency at all.
Nice solution, I give my vote for it. Less dependencies, the better
User avatar
akastargazer
 
Posts: 6
Joined: Wed Sep 18, 2013 9:24 pm
Location: Russia, Yaroslavl

Next

Return to Resolved (Bugs)

Who is online

Users browsing this forum: No registered users and 1 guest

cron