Issue-#169 ccall bug with stack management after a call

Locked

Should we incorporate these changes into the master?

Poll ended at Wed Aug 16, 2017 5:21 pm

Yes
4
67%
No
0
No votes
Abstain
2
33%
 
Total votes: 6

User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Issue-#169 ccall bug with stack management after a call

Post by Robert »

luowy
Posts: 234
Joined: Mon Oct 20, 2014 12:52 pm

Re: Issue-#169 ccall bug with stack management after a call

Post by luowy »

has bug, check my modification viewtopic.php?f=40&t=654#p6269, please.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue-#169 ccall bug with stack management after a call

Post by Josef Templ »

Thanks for pointing out the mistake, luowy.
There are several sysflags that imply untagged, so checking untagged is the right way.
I have overlooked it in your original posting. It is fixed now.

There was also a line of debug code that needed to be removed.

See diffs at: https://redmine.blackboxframework.org/p ... a6daadcd9c.

- Josef
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#169 ccall bug with stack management after a call

Post by Robert »

This vote is now for the "corrected" change.
People may change their vote if they wish.
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#169 ccall bug with stack management after a call

Post by Robert »

Please read the previous post.
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#169 ccall bug with stack management after a call

Post by Robert »

Vote passed.
Locked