Issue-#147 Adding a "Mod1" function to Math/SMath

Locked

Should we incorporate these changes into the master?

Poll ended at Fri Mar 03, 2017 9:42 am

Yes
2
40%
No
0
No votes
Abstain
3
60%
 
Total votes: 5

User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Issue-#147 Adding a "Mod1" function to Math/SMath

Post by Robert »

For the issue see https://redmine.blackboxframework.org/issues/147.
For the discussion see viewtopic.php?f=41&t=586.
For the diffs see https://redmine.blackboxframework.org/p ... bd90a41bd0.

The Strings file also includes the changes from issue 139.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue-#147 Adding a "Mod1" function to Math/SMath

Post by Josef Templ »

Robert, why did you remove the empty line at the end of System/Rsrc/Strings?
Please leave it in place.
It serves to group the added entries when adding the build information.

Note: You will still get a merge conflict with System/Rsrc/Strings.

- Josef
User avatar
DGDanforth
Posts: 1061
Joined: Tue Sep 17, 2013 1:16 am
Location: Palo Alto, California, USA
Contact:

Re: Issue-#147 Adding a "Mod1" function to Math/SMath

Post by DGDanforth »

I don't like the name Mod1.
By symmetry there should be two functions
FracF (for Floor)
FracT (for Trunc)

For backwards compatibility we keep Frac
but should add the other name FracF.

-Doug
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#147 Adding a "Mod1" function to Math/SMath

Post by Robert »

I have changed my vote to Abstain until the missing blank line issue is sorted out.
User avatar
Josef Templ
Posts: 2047
Joined: Tue Sep 17, 2013 6:50 am

Re: Issue-#147 Adding a "Mod1" function to Math/SMath

Post by Josef Templ »

Also the naming issue brought up by Doug needs further discussion.
I think the voting has been created too early.

We should continue the discussion in the issue topic.

- Josef
User avatar
Robert
Posts: 1024
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: Issue-#147 Adding a "Mod1" function to Math/SMath

Post by Robert »

Vote cancelled.
Locked