issue#-189 improving the treatment of sign in Math/SMath

Should we incorporate these changes into the master?

Poll ended at Sun Jul 08, 2018 9:11 am

Yes
6
100%
 
DGDanforth, Josef Templ, cfbsoftware, Bernhard, luowy, Robert
No
0
No votes
 
Abstain
0
No votes
 
 
Total votes : 6

issue#-189 improving the treatment of sign in Math/SMath

Postby Josef Templ » Tue Jul 03, 2018 9:11 am

This is a poll for merging the changes of issue-#189 into the master branch.
It adds the functions CopySign and SignBit to Math/SMatch and fixes the treatment of
negative zero in Sign(), SinH(), TanH, etc.

The complete diffs are https://redmine.blackboxframework.org/projects/blackbox/repository/diff?utf8=%E2%9C%93&rev=ffd616fc40b5f7cd09bc6013268ec888e3369afd&rev_to=f575addcb9672bd1be481d71627b20406d97e082.

A test version is available under http://blackboxframework.org/unstable/issue-%23189/blackbox-1.7.2-a1.1053.zip.

Please cast your votes.

- Josef
Last edited by Josef Templ on Thu Jul 05, 2018 7:41 pm, edited 1 time in total.
User avatar
Josef Templ
 
Posts: 1909
Joined: Tue Sep 17, 2013 6:50 am

Re: issue#-189 improving the treatment of sign in Math/SMath

Postby Robert » Thu Jul 05, 2018 3:16 pm

In the suggested procedure ArcTan2 a bit of commented out code has been left in grey. We might wish to change that to default colour.
User avatar
Robert
 
Posts: 914
Joined: Sat Sep 28, 2013 11:04 am
Location: Edinburgh, Scotland

Re: issue#-189 improving the treatment of sign in Math/SMath

Postby Josef Templ » Thu Jul 05, 2018 7:40 pm

done.

- Josef
User avatar
Josef Templ
 
Posts: 1909
Joined: Tue Sep 17, 2013 6:50 am


Return to Voting

Who is online

Users browsing this forum: No registered users and 1 guest

cron